Github user hmcl commented on the issue:

    https://github.com/apache/storm/pull/2465
  
    @srdo can you please do a first pass review. In the meantime I will address 
the 2 or 3 TODO with minor cleanups. The following tests are also failing. I am 
working on fixing them, but if you know from the top of your head how to fix 
these failures (I don't think they are bugs added by the patch), I would 
appreciate your tips. Thanks.
    
    ``` java
    Tests in error:
      
KafkaSpoutRebalanceTest.spoutMustIgnoreFailsForTuplesItIsNotAssignedAfterRebalance:184
 InvalidUseOfMatchers
      
KafkaSpoutRebalanceTest.testReassignPartitionSeeksForOnlyNewPartitions:244 » 
Runtime
      
MaxUncommittedOffsetTest.testNextTupleCanEmitMoreMessagesWhenDroppingBelowMaxUncommittedOffsetsDueToCommit:120
 » NullPointer
      
MaxUncommittedOffsetTest.testNextTupleWillNotEmitMoreThanMaxUncommittedOffsetsPlusMaxPollRecordsMessages:187->failAllExceptTheFirstMessageThenCommit:170
 » NullPointer
    ```


---

Reply via email to