Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157346509
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java
---
@@ -290,8 +291,8 @@ public int readyMessageCount() {
}
@Override
- public KafkaSpoutMessageId getMessageId(ConsumerRecord<?, ?> record) {
- KafkaSpoutMessageId msgId = new KafkaSpoutMessageId(record);
+ public KafkaSpoutMessageId getMessageId(ConsumerRecord<?, ?> record,
TopologyContext context) {
--- End diff --
I'm fine with this in 2.x, but for 1.2.0 I think we should try to avoid
breaking changes (RetryService is a public API, it's the same reason this
method still takes a ConsumerRecord instead of just the partition and offset).
---
