Github user satishd commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2467#discussion_r157942171
  
    --- Diff: 
external/storm-solr/src/main/java/org/apache/storm/solr/mapper/SolrJsonMapper.java
 ---
    @@ -93,6 +93,10 @@ private SolrJsonMapper(Builder builder) {
             jsonUpdateUrl = builder.jsonUpdateUrl;
         }
     
    +    @Override
    +    public void configure() {
    --- End diff --
    
    This may not be needed here once it is defined with default method in 
`SolrMapper`.


---

Reply via email to