Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2467#discussion_r158739084 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/mapper/SolrMapper.java --- @@ -26,6 +26,7 @@ import java.util.List; public interface SolrMapper extends Serializable { + void configure(); --- End diff -- Looks like major change is RestJsonSchemaBuilder. RestJsonSchemaBuilderV1 builds (fetches) schema in constructor, whereas RestJsonSchemaBuilderV2 builds (fetches) schema in `buildSchema()` which is newly added to interface in SchemaBuilder as well. So the implementation is going to require explicit initialization. How about separating this into two pull requests which for 1.x-branch is initializing schema in constructor as same as what RestJsonSchemaBuilderV1 is doing (so no need to add `configure()` and `buildSchema()`), and which for master is same as current PR?
---