Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2433#discussion_r158705607
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -4121,7 +4236,43 @@ public boolean isTopologyNameAllowed(String name) 
throws AuthorizationException,
                 throw new RuntimeException(e);
             }
         }
    -    
    +
    +    @Override
    +    public SupervisorAssignments getSupervisorAssignments(String node) 
throws AuthorizationException, TException {
    +        try {
    +            if(isLeader()) {
    +                SupervisorAssignments supervisorAssignments = new 
SupervisorAssignments();
    +                
supervisorAssignments.set_storm_assignment(assignmentsForNode(stormClusterState.assignmentsInfo(),
 node));
    +                return supervisorAssignments;
    +            }
    +        } catch (Exception e) {
    +            //when not leader just return nil which will cause client to 
get an unknown error
    --- End diff --
    
    Friendly reminder: this comment is not addressed.


---

Reply via email to