[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2433#discussion_r158705200
  
    --- Diff: 
storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
    @@ -147,21 +153,52 @@ protected void 
issueMapCallback(ConcurrentHashMap<String, Runnable> callbackConc
     
         @Override
         public List<String> assignments(Runnable callback) {
    +        //deprecated
             if (callback != null) {
                 assignmentsCallback.set(callback);
             }
    -        return stateStorage.get_children(ClusterUtils.ASSIGNMENTS_SUBTREE, 
callback != null);
    +        return this.backend.assignments();
         }
     
         @Override
         public Assignment assignmentInfo(String stormId, Runnable callback) {
    +        //deprecated
    +        if (callback != null) {
    +            assignmentInfoCallback.put(stormId, callback);
    +        }
    +        return this.backend.getAssignment(stormId);
    +    }
    +
    +    @Override
    +    public Assignment remoteAssignmentInfo(String stormId, Runnable 
callback) {
    +        //deprecated
    --- End diff --
    
    This comment is missed to addressed.


---