GitHub user OuYangLiang opened a pull request:

    https://github.com/apache/storm/pull/2494

    STORM-2880 Minor optimisation about kafka spout.

    Based on the **single responsibility principle**, method 
`isAtLeastOnceProcessing()` should reside in `KafkaSpoutConfig` rather than 
`KafkaSpout`. This patch removes the dependency of 
`KafkaSpoutConfig.ProcessingGuarantee` from `KafkaSpout`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/OuYangLiang/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2494.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2494
    
----
commit 9a983167523a26d90266c1d689f36f464e062e66
Author: ouyangliang <ouyanggod@...>
Date:   2018-01-03T08:52:42Z

    STORM-2880 Minor optimisation about kafka spout.
    Based on the single responsibility principle, method 
isAtLeastOnceProcessing() should reside in KafkaSpoutConfig rather than 
KafkaSpout. This patch removes the dependency of 
KafkaSpoutConfig.ProcessingGuarantee from KafkaSpout.

----


---

Reply via email to