Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2494
  
    Bikeshedding incoming:
    
    I'm not sure this is better. The two methods in ProcessingGuarantee are 
just named variants of equals. I think we might as well just replace the checks 
in KafkaSpout with == checks. I don't think e.g. 
`kafkaSpoutConfig.getProcessingGuarantee() == 
KafkaSpoutConfig.ProcessingGuarantee.AT_MOST_ONCE` is following the SRP any 
less than `kafkaSpoutConfig.getProcessingGuarantee().isAtMostOnceProcessing()` 
(the second one also violates the law of Demeter).


---

Reply via email to