Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2504
@HeartSaVioR sorry about that I think we probably were not clear enough on
this, what is covered and what is not currently covered by this pull request.
Reading through the description of STORM-2156 you are 100% right that this
does not cover everything there. I will file a new subtask for STORM-2156 and
we will update this pull request to be under it. I am sorry about the
confusion. Thanks for calling us out on this.
For those who care here is some more history about this patch:
Originally this work was based off of the metrics v2 patch and was done by
@abellina and @lavindev as an intern here. But it ended up being a very large
patch and it looked like it would take a very long time to go in. We would
have to wait for metrics v2 to go in, then get this reviewed and in along with
the glue code that is not here, and then have both of them ported to master.
To try and speed it up I asked @agresch to take out just the rocksdb
metrics storage piece and a small number of metrics that don't require the v2
patch, put it on master, make sure it is solid and see if we can get that in by
itself. I thought this would be great because it would at least provide the
minimum metrics needed to start looking at elasticity.
The prototype that @lavindev and @abellina includes all of the integration
with metrics v2, the UI updated to show both sets of metrics side by side so we
could judge how close they were to each other, a real time metrics graphing
proof-of-concept on the UI, and a plugin to store the metrics in HBase instead
of rocksdb. So we have code to cover all of STORM-2156 and more. We are just
trying to optimize how quickly we can get it in so we can hopefully do a 2.x
release sometime this quarter.
---
