Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2504#discussion_r160241948
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -1081,6 +1088,14 @@ public Nimbus(Map<String, Object> conf, INimbus 
inimbus, IStormClusterState stor
                 BlobStore blobStore, TopoCache topoCache, ILeaderElector 
leaderElector, IGroupMappingServiceProvider groupMapper)
             throws Exception {
             this.conf = conf;
    +
    +        this.metricsStore = null;
    --- End diff --
    
    Can we verify that if the metricsStore is null that we don't get any 
NullPointerExceptions in really bad places.


---

Reply via email to