Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2517#discussion_r162310802
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -2151,9 +2161,10 @@ private void setupBlobstore() throws 
AuthorizationException, KeyNotFoundExceptio
                 store.deleteBlob(toDelete, NIMBUS_SUBJECT);
             }
             LOG.debug("Creating list of key entries for blobstore inside 
zookeeper {} local {}", activeKeys, activeLocalKeys);
    +        CuratorFramework zkClient = BlobStoreUtils.createZKClient(conf);
    --- End diff --
    
    **`zkClient` must be guaranteed to be closed.** Please ensure `zkClient` is 
closed after `for` statement.


---

Reply via email to