Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2517#discussion_r162311410
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/KeySequenceNumber.java ---
@@ -131,9 +131,8 @@ public KeySequenceNumber(String key, NimbusInfo
nimbusInfo) {
this.nimbusInfo = nimbusInfo;
}
- public synchronized int getKeySequenceNumber(Map<String, Object> conf)
throws KeyNotFoundException {
+ public synchronized int getKeySequenceNumber(CuratorFramework
zkClient) throws KeyNotFoundException {
TreeSet<Integer> sequenceNumbers = new TreeSet<Integer>();
- CuratorFramework zkClient = BlobStoreUtils.createZKClient(conf);
--- End diff --
You should remove `finally` statement since it is no longer created in this
method, it's being passed from caller. Caller should have responsibility to
close this.
---
