[GitHub] storm pull request #2504: STORM-2887: store metrics into RocksDB

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2504#discussion_r162322576
  
    --- Diff: storm-client/src/storm.thrift ---
    @@ -836,3 +837,24 @@ exception HBAuthorizationException {
     exception HBExecutionException {
       1: required string msg;
     }
    +
    +struct WorkerMetricFields {
    --- End diff --
    
    You could check importing ttypes.py to see it works fine. If current patch 
doesn't break ttypes.py please ignore my comment.


---