[GitHub] storm pull request #2504: STORM-2887: store metrics into RocksDB

[agresch]

Github user agresch commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2504#discussion_r162634637
  
    --- Diff: storm-server/pom.xml ---
    @@ -64,6 +64,10 @@
                 <artifactId>auto-service</artifactId>
                 <optional>true</optional>
             </dependency>
    +        <dependency>
    +            <groupId>org.rocksdb</groupId>
    +            <artifactId>rocksdbjni</artifactId>
    --- End diff --
    
    I tested on a mac and a RHEL vm.  The rocksDB jar also contains a win64 jni 
dll.  If an error is thrown creating the metrics store, everything should be 
treated as a noop.   


---