Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2531#discussion_r163729225
--- Diff:
storm-client/src/jvm/org/apache/storm/security/auth/kerberos/ServerCallbackHandler.java
---
@@ -18,79 +18,86 @@
package org.apache.storm.security.auth.kerberos;
+import javax.security.sasl.RealmCallback;
import org.apache.storm.security.auth.AuthUtils;
import org.apache.storm.security.auth.ReqContext;
-import org.apache.storm.security.auth.SaslTransportPlugin;
+import org.apache.storm.security.auth.sasl.SaslTransportPlugin;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import javax.security.auth.Subject;
import javax.security.auth.callback.*;
import javax.security.auth.login.AppConfigurationEntry;
import javax.security.auth.login.Configuration;
import javax.security.sasl.AuthorizeCallback;
import java.io.IOException;
-import java.util.Map;
/**
- * SASL server side callback handler
+ * SASL server side callback handler for kerberos auth.
*/
public class ServerCallbackHandler implements CallbackHandler {
private static final Logger LOG =
LoggerFactory.getLogger(ServerCallbackHandler.class);
- private String userName;
-
- public ServerCallbackHandler(Configuration configuration, Map<String,
Object> topoConf) throws IOException {
- if (configuration==null) return;
+ public ServerCallbackHandler(Configuration configuration) throws
IOException {
+ if (configuration == null) {
+ return;
+ }
AppConfigurationEntry configurationEntries[] =
configuration.getAppConfigurationEntry(AuthUtils.LOGIN_CONTEXT_SERVER);
if (configurationEntries == null) {
String errorMessage = "Could not find a
'"+AuthUtils.LOGIN_CONTEXT_SERVER+"' entry in this configuration: Server cannot
start.";
--- End diff --
spacing.
---
