Github user roshannaik commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2502#discussion_r167383283
  
    --- Diff: storm-client/src/jvm/org/apache/storm/daemon/Acker.java ---
    @@ -99,17 +100,19 @@ public void execute(Tuple input) {
                 pending.put(id, curr);
             } else if (ACKER_RESET_TIMEOUT_STREAM_ID.equals(streamId)) {
                 resetTimeout = true;
    -            if (curr != null) {
    +            if (curr == null) {
    --- End diff --
    
    Unintentional. This appears to be due a mistake most likely when resolving 
merge conflicts when I rebased my code to master sometime in Dec 2017. Will 
revert. Thanks for catching.


---

Reply via email to