Github user HeartSaVioR commented on a diff in the pull request:
    --- Diff: 
    @@ -22,19 +22,23 @@
     import org.apache.storm.executor.TupleInfo;
     import org.apache.storm.spout.ISpout;
     import org.apache.storm.spout.ISpoutOutputCollector;
    +import org.apache.storm.tuple.AddressedTuple;
     import org.apache.storm.tuple.MessageId;
     import org.apache.storm.tuple.TupleImpl;
     import org.apache.storm.tuple.Values;
    -import org.apache.storm.utils.Utils;
     import org.apache.storm.utils.MutableLong;
     import org.apache.storm.utils.RotatingMap;
    +import org.apache.storm.utils.Utils;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
     import java.util.ArrayList;
     import java.util.List;
     import java.util.Random;
    +// Methods are not thread safe. Each thread expected to have a separate 
instance, or else synchronize externally
    --- End diff --
    nit: better to make it as javadoc so that it can be exposed to more ways.
    As @revans2 stated, I also think this is a good assumption for a spout, but 
even better to update the restriction if we have documented any. That's just a 
2 cents, not blocker.


Reply via email to