Github user HeartSaVioR commented on a diff in the pull request:
    --- Diff: 
    @@ -22,19 +22,23 @@
     import org.apache.storm.executor.TupleInfo;
     import org.apache.storm.spout.ISpout;
     import org.apache.storm.spout.ISpoutOutputCollector;
    +import org.apache.storm.tuple.AddressedTuple;
     import org.apache.storm.tuple.MessageId;
     import org.apache.storm.tuple.TupleImpl;
     import org.apache.storm.tuple.Values;
    -import org.apache.storm.utils.Utils;
     import org.apache.storm.utils.MutableLong;
     import org.apache.storm.utils.RotatingMap;
    +import org.apache.storm.utils.Utils;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
     import java.util.ArrayList;
     import java.util.List;
     import java.util.Random;
    +// Methods are not thread safe. Each thread expected to have a separate 
instance, or else synchronize externally
    --- End diff --
    I thought STORM-2945 was filed to find the way to support background emit 
without external synchronization, so likely having the chance to keep 
unresolved in 2.x. If you intended to document how to enable background emit 
with current state in STORM-2945, please ignore the comment here.


Reply via email to