Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2595#discussion_r175893945
--- Diff: .gitattributes ---
@@ -1,2 +1,2 @@
# Some storm-webapp logviewer tests require input files to have LF line
endings due to byte counting.
-storm-webapp/src/test/resources/*.log.test text eol=lf
\ No newline at end of file
+* text=auto
--- End diff --
I agree that it makes sense to force LF on check in, but we should maybe
ensure some files are excluded, e.g. png and svgs and other image files. We
have a couple in the docs.
---
