Github user krichter722 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2595#discussion_r175918249
--- Diff: .gitattributes ---
@@ -1,2 +1,2 @@
# Some storm-webapp logviewer tests require input files to have LF line
endings due to byte counting.
-storm-webapp/src/test/resources/*.log.test text eol=lf
\ No newline at end of file
+* text=auto
--- End diff --
`text` automatically recognizes text formats (according to
https://git-scm.com/docs/gitattributes) and I doubt that `git` handles this
badly. PNG is binary and SVG is text-based, so afaik PNG would be excluded
automatically and SVG's EOL whould be converted to LF on check-in which makes
sense. The conversion should be done once manually with `git rm -r --cached &&
git add .`.
---
