Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2591#discussion_r178093387
--- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
@@ -566,9 +566,12 @@
worker-topology-context (worker-context worker)
hooks (.get_worker_hooks topology)]
(dofor [hook hooks]
- (let [hook-bytes (Utils/toByteArray hook)
- deser-hook (Utils/javaDeserialize hook-bytes BaseWorkerHook)]
- (.start deser-hook topo-conf worker-topology-context)))))
+ (let [savedposition (.position hook)
--- End diff --
I'm OK if you just make change to new squashed commit, since the diff will
be one-liner or couple of lines. Sure I'm also OK to see new commit and squash
later.
---
