Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2591#discussion_r179904186
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
    @@ -585,6 +588,8 @@
     (defserverfn mk-worker [conf shared-mq-context storm-id assignment-id port 
worker-id]
       (log-message "Launching worker for " storm-id " on " assignment-id ":" 
port " with id " worker-id
                    " and conf " conf)
    +  ;; create an empty list to store deserialized hooks
    +  (def deserialized-hooks (java.util.ArrayList.))
    --- End diff --
    
    It would be better to include this in `worker-data` so that it can be 
reused at any time. Please add this to the returning recursive-map in 
`worker-data` function, and refer it from other functions.


---

Reply via email to