Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2618#discussion_r178852812
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
    @@ -497,7 +497,6 @@ static DynamicState 
cleanupCurrentContainer(DynamicState dynamicState, StaticSta
             assert(dynamicState.container.areAllProcessesDead());
             
             dynamicState.container.cleanUp();
    -        
staticState.localizer.releaseSlotFor(dynamicState.currentAssignment, 
staticState.port);
    --- End diff --
    
    That is not true.
    
    
https://github.com/danny0405/storm/blob/a4e659b5073794396ea23e3dd7b79c00536fc3fe/storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java#L505-L511
    
    The code first removes the base blobs reference counts, but then it 
decrements a reference count for other blobs too.


---

Reply via email to