Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2639#discussion_r187555046
--- Diff:
external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
@@ -127,8 +130,14 @@ public void setJmsAcknowledgeMode(final int mode) {
messageHandler = new TransactedSessionMessageHandler();
break;
default:
- LOG.warn("Unsupported Acknowledge mode: "
- + mode + " (See javax.jms.Session for valid values)");
+ // individual message ack-ing needs vendor specific mode
+ if (individualAcks) {
--- End diff --
This change requires end users to call individualAcks earlier than this
method. Could we guide this in javadoc or in exception message? Or can we fix
it? (Maybe it defers verification step in open() so violating fail-fast...)
---
