Github user ptgoetz commented on the issue:

    https://github.com/apache/storm/pull/2639
  
    Looks good to me. +1
    
    I was wondering why you removed the `distributed` flag, and realized it was 
never properly implemented! For it to work, we would need the following method 
override:
    
    ```java
        @Override
        public Map<String, Object> getComponentConfiguration() {
            if(!_isDistributed) {
                Map<String, Object> ret = new HashMap<String, Object>();
                ret.put(Config.TOPOLOGY_MAX_TASK_PARALLELISM, 1);
                return ret;
            } else {
                return null;
            }
        }    
    ```
    
    I can see cases where that flag would be useful, for example when 
connecting to a topic vs. a queue. We may want to leave the flag there and fix 
the override.


---

Reply via email to