Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2704#discussion_r193462962
  
    --- Diff: storm-core/pom.xml ---
    @@ -456,29 +456,29 @@
                     </configuration>
                 </plugin>
                 <plugin>
    -               <groupId>org.apache.storm</groupId>
    -               <artifactId>storm-maven-plugins</artifactId>
    -               <version>${project.version}</version>
    -               <executions>
    -                 <execution>
    -                   <id>version-info</id>
    -                   <phase>generate-resources</phase>
    -                   <goals>
    -                     <goal>version-info</goal>
    -                   </goals>
    -                   <configuration>
    -                   <source>
    -                      <directory>${basedir}/src/</directory>
    -                      <includes>
    -                        <include>jvm/**/*.java</include>
    -                        <include>clj/**/*.clj</include>
    -                      </includes>
    -                  </source>
    -                 </configuration>
    -               </execution>
    -             </executions>
    -          </plugin>
    -          <plugin>
    +                <groupId>org.apache.storm</groupId>
    +                <artifactId>storm-maven-plugins</artifactId>
    +                <version>${project.version}</version>
    +                <executions>
    +                    <execution>
    +                        <id>version-info</id>
    +                        <phase>generate-resources</phase>
    +                        <goals>
    +                            <goal>version-info</goal>
    +                        </goals>
    +                        <configuration>
    +                            <source>
    +                                <directory>${basedir}/src/</directory>
    +                                <includes>
    +                                    <include>jvm/**/*.java</include>
    +                                    <include>clj/**/*.clj</include>
    +                                </includes>
    +                            </source>
    +                        </configuration>
    +                    </execution>
    +                </executions>
    +            </plugin>
    +            <plugin>
    --- End diff --
    
    This was also indented inconsistently (3 spaces where the rest of the file 
is 4)


---

Reply via email to