Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2735#discussion_r197654356
--- Diff: storm-core/test/clj/org/apache/storm/metrics_test.clj ---
@@ -87,12 +91,22 @@
(first) ;; pick first task in the list, ignore other tasks' metric
data.
(second)
(or [])))
-
-(defmacro assert-buckets! [comp-id metric-name expected cluster]
- `(do
- (let [N# (count ~expected)]
- (wait-for-atleast-N-buckets! N# ~comp-id ~metric-name ~cluster)
- (is (= ~expected (subvec (lookup-bucket-by-comp-id-&-metric-name!
~comp-id ~metric-name) 0 N#))))))
+
+(defn assert-metric-running-sum! [comp-id metric-name expected min-buckets
cluster]
+ (try
+ (do
+ (wait-for-atleast-N-buckets! min-buckets comp-id metric-name cluster)
+ (.until
--- End diff --
Thanks for the details. Now I can understand what the patch is addressing
clearer.
---
