Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2735#discussion_r197962370
  
    --- Diff: storm-core/pom.xml ---
    @@ -184,6 +184,10 @@
                 <artifactId>mockito-core</artifactId>
                 <scope>test</scope>
             </dependency>
    +        <dependency>
    +            <groupId>org.awaitility</groupId>
    +            <artifactId>awaitility</artifactId>
    +        </dependency>
    --- End diff --
    
    I'm not sure we are consistent regarding this, but IMHO explicitly marking 
it looks better for me, though we know the scope is inherited. I'm OK if we are 
already not consistent on this.


---

Reply via email to