Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199531108
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/timed/TimerDecorated.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements.
+ * See the NOTICE file distributed with this work for additional
information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
(the "License");
+ * you may not use this file except in compliance with the License. You
may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an "AS IS"
BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
limitations under the License.
+ */
+
+package org.apache.storm.metric.timed;
+
+import com.codahale.metrics.Timer;
+
+import java.util.concurrent.atomic.AtomicReference;
+
+public interface TimerDecorated extends AutoCloseable {
+
+ boolean hasStopped();
+
+ default boolean hasStopped(final AtomicReference<Timer.Context>
timing) {
+ return timing.get() == null;
+ }
+
+ long stopTiming();
--- End diff --
I'm actually modeling so after the implementation of dropwizard's Timer
class. Basically the object can behave like an Autocloseable and put in
try-with-resource block or specialized collections (such as TimeCacheMap). In a
way, close method is not for users to call and user should either invoke stop
timing or rely on `Autocloseable`'s behavior. But yeah now I think for
robustness maybe `stopTiming` should be idempotent instead of only a one time
call.
---
