Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199531884
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/timed/TimerDecorated.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements.
+ * See the NOTICE file distributed with this work for additional
information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
(the "License");
+ * you may not use this file except in compliance with the License. You
may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an "AS IS"
BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
limitations under the License.
+ */
+
+package org.apache.storm.metric.timed;
+
+import com.codahale.metrics.Timer;
+
+import java.util.concurrent.atomic.AtomicReference;
+
+public interface TimerDecorated extends AutoCloseable {
+
+ boolean hasStopped();
+
+ default boolean hasStopped(final AtomicReference<Timer.Context>
timing) {
+ return timing.get() == null;
+ }
+
+ long stopTiming();
--- End diff --
Also I'm not sure if the current design is best for extensibility. I can
think of a scenario when you want to have different timer or track time in
different phase (say you want to measure not only how long it takes to launch
an assignment but how long it runs on a worker). Should I make it more flexible
so it's easier to maintain in the future?
---
