Stig, I started reviewing your pull requests. There would be conflicts between 1.x-branch as well as conflicts between pull requests, so please follow up some following-up requests if any.
Btw I'll rebase STORM-2406 to make it getting review again. Thanks, Jungtaek Lim (HeartSaVioR) 2018년 7월 8일 (일) 오전 1:54, Stig Rohde Døssing <[email protected]>님이 작성: > Hugo, > > Sounds good, thanks. > > Jungtaek, > > I don't think there are any missing tasks in STORM-2953. Once the listed > tasks are done, we should be good to delete storm-kafka. I've been holding > off on looking at https://issues.apache.org/jira/browse/STORM-2972 because > I was hoping that https://github.com/apache/storm/pull/2443 could go in > first. > > 2018-07-07 0:21 GMT+02:00 Hugo Louro <[email protected]>: > > > I’ll take a pass at reviewing them as well. > > Thanks, > > Hugo > > > > > On Jul 6, 2018, at 1:41 PM, Jungtaek Lim <[email protected]> wrote: > > > > > > Yeah I have been hoping that some other folks who are familiar with > > > storm-kafka-client jump in and review in time, but unfortunately it > > didn't > > > happen. Will try to review those PRs, hopefully within couple of days. > > > > > > Btw, if there're missing PRs to resolve STORM-2953 > > > <https://issues.apache.org/jira/browse/STORM-2953> I'd like to ask you > > to > > > also add them here, so we can resolve the one which is effectively > > blocker > > > for Storm 2.0. > > > > > > Thanks, > > > Jungtaek Lim (HeartSaVioR) > > > > > > 2018년 7월 6일 (금) 오후 9:08, Stig Rohde Døssing <[email protected]>님이 > > 작성: > > > > > >> Hi devs, > > >> > > >> There are a couple of PRs open for changes in storm-kafka-client that > > would > > >> be nice to get reviewed. The PRs are > > >> https://github.com/apache/storm/pull/2652 > > >> https://github.com/apache/storm/pull/2648 and > > >> https://github.com/apache/storm/pull/2590. If someone could find a > > couple > > >> of minutes to give them a look, I'd appreciate it. > > >> > > >> Thanks. > > >> > > >
