Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2752#discussion_r204259623
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/daemon/drpc/webapp/ReqContextFilter.java ---
    @@ -28,10 +28,14 @@
     import javax.servlet.ServletResponse;
     import javax.servlet.http.HttpServletRequest;
     import javax.servlet.http.HttpServletResponse;
    +import javax.ws.rs.container.PreMatching;
    +import javax.ws.rs.ext.Provider;
     
     import org.apache.storm.security.auth.IHttpCredentialsPlugin;
     import org.apache.storm.security.auth.ReqContext;
     
    +@Provider
    +@PreMatching
     public class ReqContextFilter implements Filter {
    --- End diff --
    
    Once UI also leverages this class, I feel we would be better to have common 
package on webservice, and move this class to there.


---

Reply via email to