Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r204259460
--- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj ---
@@ -1613,24 +1613,24 @@
https-want-client-auth (conf UI-HTTPS-WANT-CLIENT-AUTH)
https-need-client-auth (conf UI-HTTPS-NEED-CLIENT-AUTH)]
(StormMetricsRegistry/startMetricsReporters conf)
- (UIHelpers/stormRunJetty (int (conf UI-PORT))
- (conf UI-HOST)
- https-port
- header-buffer-size
- (reify IConfigurator
+ (UIHelpers/stormRunJetty (int (conf UI-PORT))
+ (conf UI-HOST)
+ https-port
+ header-buffer-size
+ (reify IConfigurator
(execute [this server]
(UIHelpers/configSsl server
- https-port
- https-ks-path
- https-ks-password
- https-ks-type
- https-key-password
- https-ts-path
- https-ts-password
- https-ts-type
- https-need-client-auth
- https-want-client-auth
- header-buffer-size)
+ https-port
+ https-ks-path
+ https-ks-password
+ https-ks-type
+ https-key-password
+ https-ts-path
+ https-ts-password
+ https-ts-type
+
https-need-client-auth
+
https-want-client-auth
+
header-buffer-size)
--- End diff --
I think we will remove clj files later, but let's revert unneeded changes
so that we can see smaller set of change.---
