Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204860271
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -65,21 +67,41 @@ public static Meter registerMeter(final String name) {
* @param <V> type of value the gauge measures
*/
public static <V> void registerProvidedGauge(final String name, final
Gauge<V> gauge) {
- register(name, gauge);
+ DEFAULT_REGISTRY.register(name, gauge);
+ }
+
+ public static Histogram registerHistogram(String name) {
--- End diff --
Nit: Might be helpful to add a note to the javadoc here that it uses this
particular reservoir, or maybe rename the method to describe it, e.g.
`registerFiveMinuteHistogram` or something like that.
---
