Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r204915515
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -65,21 +67,41 @@ public static Meter registerMeter(final String name) {
* @param <V> type of value the gauge measures
*/
public static <V> void registerProvidedGauge(final String name, final
Gauge<V> gauge) {
- register(name, gauge);
+ DEFAULT_REGISTRY.register(name, gauge);
+ }
+
+ public static Histogram registerHistogram(String name) {
--- End diff --
I observed that most of the histogram we used has
ExponentiallyDecayingReservoir as default, so I was thinking we have a default
method. Notice that ExponentiallyDecayingReservoir is also the the default when
invoking `MetricRegistry#histogram(String name)`.
---
