Github user dfdemar commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207560866
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -129,6 +140,27 @@ public void prepare(Map<String, Object> topoConf,
TopologyContext context, Outpu
return new KafkaProducer<>(props);
}
+ /**
+ * Make the producer Callback. Using this Callback will also execute
the user defined Callback, if provided.
+ */
+ protected Callback mkProducerCallback(final Tuple input) {
--- End diff --
Fair point. I'll change it to `private`.
---
