Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2790#discussion_r207671937
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -62,6 +62,7 @@
private OutputCollector collector;
private TupleToKafkaMapper<K,V> mapper;
private KafkaTopicSelector topicSelector;
+ private Callback providedCallback;
--- End diff --
That looks good to me. I'm also not sure about the collector, but I'd maybe
lean toward not including it. The callback won't have access to incoming
tuples, so the only use would be if someone wanted the callback to emit a new
unanchored tuple.
I wouldn't worry about people misusing the prepare method. They can just as
easily override the bolt's prepare method.
---
