Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2789#discussion_r208005815
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java
---
@@ -446,6 +447,7 @@ public void
sendSupervisorAssignments(SupervisorAssignments assignments) {
public void close() {
try {
LOG.info("Shutting down supervisor {}", getId());
+ metricsReporters.close();
--- End diff --
Nit: This should probably have a null check, since metricsReporters isn't
guaranteed to be non-null.
---
