Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2789#discussion_r208012336
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -53,12 +55,14 @@ public static Meter registerMeter(String name) {
*
* @param topoConf config that specifies reporter plugin
*/
- public static void startMetricsReporters(Map<String, Object> topoConf)
{
- for (PreparableReporter reporter :
MetricsUtils.getPreparableReporters(topoConf)) {
+ public static AutoCloseable startMetricsReporters(Map<String, Object>
topoConf) {
--- End diff --
Okay. Do we want this to be a generic utility interface or specific to
reporters then?
---
