Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r208703547
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -95,6 +102,9 @@ public LogCleaner(Map<String, Object> stormConf,
WorkerLogs workerLogs, Director
LOG.info("configured max total size of worker logs: {} MB, max
total size of worker logs per directory: {} MB",
maxSumWorkerLogsSizeMb, maxPerWorkerLogsSizeMb);
+ //Switch to CachedGauge if this starts to hurt performance
+ //
https://stackoverflow.com/questions/5857199/how-to-find-out-the-size-of-file-and-directory-in-java-without-creating-the-obje
--- End diff --
remove link
---
