[GitHub] storm pull request #2754: STORM-3133: Extend metrics on Nimbus and LogViewer

[Ethanlm]

Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r208703040
  
    --- Diff: 
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/DirectoryCleaner.java
 ---
    @@ -186,7 +192,22 @@ private boolean isFileEligibleToSkipDelete(boolean 
forPerDir, Set<String> active
                         break;
                     }
                 }
    +        } catch (IOException e) {
    +            ExceptionMeters.NUM_FILE_OPEN_EXCEPTIONS.mark();
    --- End diff --
    
    better to use `NUM_FILE_SCANNED_EXCEPTIONS`?


---