Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2801#discussion_r209438732
  
    --- Diff: storm-client/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
    @@ -52,6 +79,16 @@ public static ConfigUtils setInstance(ConfigUtils u) {
             return oldInstance;
         }
     
    +    public static Map<String, Object> maskPasswords(final Map<String, 
Object> conf) {
    +        Maps.EntryTransformer<String, Object, Object> maskPasswords =
    --- End diff --
    
    @arunmahadevan 
    Ah OK that makes sense. I should have made clear that my concern was adding 
guava to the dependency without shading. You can revert the logic with using 
shaded guava.
    
    https://github.com/apache/storm/blob/master/shaded-deps/pom.xml#L207-L218
    
    Sorry about the confusion.


---

Reply via email to