Github user HeartSaVioR commented on a diff in the pull request:
    --- Diff: storm-client/src/jvm/org/apache/storm/utils/ ---
    @@ -52,6 +79,16 @@ public static ConfigUtils setInstance(ConfigUtils u) {
             return oldInstance;
    +    public static Map<String, Object> maskPasswords(final Map<String, 
Object> conf) {
    +        Maps.EntryTransformer<String, Object, Object> maskPasswords =
    --- End diff --
    I also think this approach can replace `Utils.radactValue` via adding 
    What do you think? Looks like we don't need to have both approach.


Reply via email to