[GitHub] storm pull request #2852: STORM-3237 track Nimbus mkAssignment failures

[kishorvpatil]

Github user kishorvpatil commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2852#discussion_r221257606
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -2850,6 +2853,7 @@ public void launchServer() throws Exception {
                                                 }
                                                 doCleanup();
                                             } catch (Exception e) {
    +                                            
this.mkAssignmentsErrors.mark();
    --- End diff --
    
    should we have separate tracker for cleanup failures and `doCleanup()` ?


---