[GitHub] storm pull request #2852: STORM-3237 track Nimbus mkAssignment failures

[revans2]

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2852#discussion_r221331973
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -2162,7 +2165,12 @@ private boolean isReadyForMKAssignments() throws 
Exception {
         }
     
         private void mkAssignments() throws Exception {
    -        mkAssignments(null);
    +        try {
    +            mkAssignments(null);
    --- End diff --
    
    Do we want to make the change inside `mkAssignments(String scratchTopoId)` 
so we can count errors during the rebalance command as well?


---