HeartSaVioR commented on a change in pull request #2945: STORM-3321: Fix race
in LocalCluster regarding Nimbus leadership, red…
URL: https://github.com/apache/storm/pull/2945#discussion_r260449850
##########
File path: storm-server/src/main/java/org/apache/storm/LocalCluster.java
##########
@@ -231,6 +233,10 @@ private LocalCluster(Builder builder) throws Exception {
} else {
this.clusterState = builder.clusterState;
}
+ if (!Time.isSimulating()) {
+ //Ensure Nimbus assigns topologies as quickly as possible
+ conf.put(DaemonConfig.NIMBUS_MONITOR_FREQ_SECS, 1);
Review comment:
Is this change also useful for other cases (non-test) as well? If we are
unsure about it, could we setup global config for non time simulating test and
add this to there instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
