HeartSaVioR commented on a change in pull request #2945: STORM-3321: Fix race
in LocalCluster regarding Nimbus leadership, red…
URL: https://github.com/apache/storm/pull/2945#discussion_r260450781
##########
File path: storm-server/src/main/java/org/apache/storm/LocalCluster.java
##########
@@ -690,6 +700,10 @@ public synchronized Supervisor addSupervisor(Number
ports, Map<String, Object> c
}
superConf.put(Config.STORM_LOCAL_DIR, tmpDir.getPath());
superConf.put(DaemonConfig.SUPERVISOR_SLOTS_PORTS, portNumbers);
+ if (!Time.isSimulating()) {
+ //Monitor for assignment changes as often as possible, so e.g.
shutdown happens as fast as possible.
Review comment:
same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
