HeartSaVioR commented on a change in pull request #2961: STORM-3344 prevent
blacklist scheduler runtime exeception removing fr…
URL: https://github.com/apache/storm/pull/2961#discussion_r264458782
##########
File path:
storm-server/src/test/java/org/apache/storm/scheduler/blacklist/TestBlacklistScheduler.java
##########
@@ -329,11 +329,51 @@ public void removeLongTimeDisappearFromCache(){
Assert.assertEquals(cached, bs.cachedSupervisors.keySet());
cluster = new Cluster(iNimbus, resourceMetrics, supMap, new
HashMap<String, SchedulerAssignmentImpl>(), topologies, config);
bs.schedule(topologies,cluster);
- cluster = new Cluster(iNimbus, resourceMetrics,
TestUtilsForBlacklistScheduler.removePortFromSupervisors(supMap,"sup-0",0),TestUtilsForBlacklistScheduler.assignmentMapToImpl(cluster.getAssignments()),
topologies, config);
+ cluster = new Cluster(iNimbus, resourceMetrics,
TestUtilsForBlacklistScheduler.modifyPortFromSupervisors(supMap,"sup-0",0,
false),TestUtilsForBlacklistScheduler.assignmentMapToImpl(cluster.getAssignments()),
topologies, config);
Review comment:
nit: space after each `,`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
