HeartSaVioR commented on a change in pull request #2961: STORM-3344 prevent
blacklist scheduler runtime exeception removing fr…
URL: https://github.com/apache/storm/pull/2961#discussion_r264458134
##########
File path:
storm-server/src/test/java/org/apache/storm/scheduler/blacklist/TestUtilsForBlacklistScheduler.java
##########
@@ -67,15 +67,19 @@
return retList;
}
- public static Map<String, SupervisorDetails>
removePortFromSupervisors(Map<String, SupervisorDetails> supervisorDetailsMap,
String supervisor, int port) {
+ public static Map<String, SupervisorDetails>
modifyPortFromSupervisors(Map<String, SupervisorDetails> supervisorDetailsMap,
String supervisor, int port, boolean add) {
Review comment:
I know that's for reusing most of the code, but having boolean flag to
determine the behavior doesn't seem to be intuitive.
Could we have two separate methods (addPort/removePort) as public methods
which call this, and make this private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
