srdo commented on issue #2980: STORM-3361: Include dependency license file in distributions, clean u… URL: https://github.com/apache/storm/pull/2980#issuecomment-476748789 Here's what changed: * Some dependencies (JUnit) were compile scope when they shouldn't be. * Removed the NOTICE/LICENSE files from storm-dist, and replaced them with updated versions called LICENSE-binary/NOTICE-binary in the project root. * Made some adjustments to storm-dist to make it easier to get an idea of the dependencies being included. Specifically, I've added modules to storm-dist to make dependencies of final-package visible to the license plugin. Before, we were just copying files from unrelated modules. This should allow us to use the license plugin to get a mostly complete list of dependencies for storm-dist/binary. I believe the only missing licenses are shaded-deps, which were easily added using `mvn dependency:tree`. * NOTICE-binary is now the source NOTICE, plus appended NOTICEs from all storm-dist/binary dependencies. * LICENSE-binary is now source LICENSE, plus slightly edited output from the license plugin for storm-dist/binary. As far as I can tell, the only part missing is regarding copyright notices. Many licenses (e.g. MIT) start with a copyright declaration, which must be included in downstream work. I'm not sure whether we can get that automatically.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
